Create/Delete HealthCheckProbeCR from DNSRecord Reconciler #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymvavilov
force-pushed
the
gh-144
branch
2 times, most recently
from
ec73121
to
526484f
Compare
maksymvavilov
changed the title
maksymvavilov
commented
Oct 16, 2024
| } | ||
| }) | ||
|
|
||
| It("Should create valid probe CRs and remove them on DNSRecord deletion", func() { |
There was a problem hiding this comment.
Creating a trivial integration check. At this moment we can only verify the creation of CR to our liking and a correct removal. Will expand in tests as the work progresses
maksymvavilov
force-pushed
the
gh-144
branch
4 times, most recently
from
199216c
to
5b48831
Compare
Signed-off-by: Maskym Vavilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create and delete
DNSHealthProbeCRs during reconciliation of the DNSRecords.This replaced logic in
internal/controller/dnsrecord_healthchecks.goto create new healthchecks but does not remove the code that would generate old healthchecks.