Owned DNS Records will block Managed Zone deletion #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbrookes
changed the title
philbrookes
changed the title
mikenairn
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
As discussed offline I'm not really sure if there is a lot of point adding this change considering we can't prevent the secrets being removed, but mostly because we want to remove the ManagedZone API anyway. That said, it looks fine, so can be merged if desired.
| } else if recordsExist { | ||
| logger.Info("ManagedZone deletion awaiting removal of owned DNS records") | ||
| return ctrl.Result{Requeue: true}, nil | ||
| } |
There was a problem hiding this comment.
Should this re-queue? Do the owner records not cause this to reconcile on change anyway?
| Expect(client.IgnoreNotFound(err)).ToNot(HaveOccurred()) | ||
| } | ||
| if brokenZone != nil { | ||
| err := k8sClient.Delete(ctx, brokenZone) | ||
| err := k8sClient.Delete(ctx, brokenZone, client.PropagationPolicy(metav1.DeletePropagationForeground)) |
There was a problem hiding this comment.
Not sure these make any difference unless you set the owner ref up with block owner deletion https://kubernetes.io/docs/concepts/overview/working-with-objects/owners-dependents/#ownership-and-finalizers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.