Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version and fix broken link #513

Merged
merged 1 commit into from
Jan 16, 2025
Merged

add version and fix broken link #513

merged 1 commit into from
Jan 16, 2025

Conversation

laurafitzgerald
Copy link
Contributor

  • Adding latest as the version to docs links
  • update kuadrant-operator/doc/auth to kuadrant-operator/doc/overviews/auth as the old link wasn't valid anymore.

@laurafitzgerald
Copy link
Contributor Author

Hey @R-Lawton I believe you were working on some docs stuff lately. I had to fix up some links here because they didn't reference any version and were producing 404s. I had a thought that there may be some mechanism that it could default to latest if the version isn't specified in the route. Do you know where would be best to create an issue for that? Under Kuadrant/docs.kuadrant.io#173 or somewhere else?

@R-Lawton
Copy link
Contributor

R-Lawton commented Jan 13, 2025

Hey @R-Lawton I believe you were working on some docs stuff lately. I had to fix up some links here because they didn't reference any version and were producing 404s. I had a thought that there may be some mechanism that it could default to latest if the version isn't specified in the route. Do you know where would be best to create an issue for that? Under Kuadrant/docs.kuadrant.io#173 or somewhere else?

Howdy a good place to do this would be in the docs repo https://github.com/Kuadrant/docs.kuadrant.io. We have two aliases already https://github.com/Kuadrant/docs.kuadrant.io?tab=readme-ov-file#mike-aliases for latest and dev they automatically bring you to the correct version but no alias for if latest isn't given.

@laurafitzgerald
Copy link
Contributor Author

Thanks Rachel. Issue created Kuadrant/docs.kuadrant.io#170

@laurafitzgerald laurafitzgerald requested review from R-Lawton and KevFan and removed request for R-Lawton January 14, 2025 10:01
Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me 👍

@laurafitzgerald laurafitzgerald force-pushed the docs-link-version branch 5 times, most recently from 77d2fca to 564b644 Compare January 14, 2025 14:32
Signed-off-by: Laura Fitzgerald <[email protected]>
@laurafitzgerald laurafitzgerald merged commit 64ff252 into main Jan 16, 2025
12 checks passed
@@ -52,7 +52,7 @@ The above will install the latest build of the Authorino Operator and latest ver

This step will also install [cert-manager](https://github.com/jetstack/cert-manager) in the cluster (required).

Alternatively, you can deploy the Authorino Operator using the Operator Lifecycle Manager bundles. For instructions, check out [Installing via OLM](https://docs.kuadrant.io/authorino-operator/#installing-via-olm).
Alternatively, you can deploy the Authorino Operator using the Operator Lifecycle Manager bundles. For instructions, check out [Installing via OLM](https://docs.kuadrant.io/latest/authorino-operator/#installing-via-olm).
Copy link
Member

@jasonmadigan jasonmadigan Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-martin interesting one - authorino-operator still exists after we've removed from nav in mkdocs, so we may need to purge these on gh-pages as part of the general cleanup? will create an issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants