Add observability section & diagrams to arch #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Martin <[email protected]>
guicassolato
approved these changes
Jul 25, 2024
Co-authored-by: Guilherme Cassolato <[email protected]> Signed-off-by: David Martin <[email protected]>
david-martin
force-pushed
the
observability-arch
branch
from
ce497c7 to
932cc6d
Compare
R-Lawton
reviewed
Jul 25, 2024
| The Kuadrant architecture is intended to work with some popular monitoring tools for tracing, metrics and log aggregation. | ||
| Those tools are: | ||
|
|
||
| - [Prometheus](https://prometheus.io/) for scraping metrics - and optionally [Thanos](https://github.com/thanos-io/thanos) for high availability & federation |
There was a problem hiding this comment.
Do we want to mention Alerts with Prometheus not just metrics? We have some example alerts with more to come
There was a problem hiding this comment.
Suggested change
| - [Prometheus](https://prometheus.io/) for scraping metrics - and optionally [Thanos](https://github.com/thanos-io/thanos) for high availability & federation | |
| - [Prometheus](https://prometheus.io/) for scraping metrics & alert rule evaluation - and optionally [Thanos](https://github.com/thanos-io/thanos) for high availability & federation |
@R-Lawton good catch. This sufficient for here?
There was a problem hiding this comment.
Yeah i think thats perfecto, Im thinking maybe added to the diagrams too, but ill leave that up to what you think
maleck13
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Kuadrant/docs.kuadrant.io#75