Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-0002: Remove filter_state from the explicitly supported attributes #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RFC-0002: Remove filter_state from the explicitly supported attributes #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions rfcs/0002-well-known-attributes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ These two subsets of attributes are unified into a single set of well-known attr
The next sections specify the well-known attributes organized in the following groups:
- [Request attributes](#request-attributes)
- [Connection attributes](#connection-attributes)
- [Metadata and filter state attributes](#metadata-and-filter-state-attributes)
- [Metadata attribute](#metadata-and-filter-state-attributes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Metadata attribute](#metadata-and-filter-state-attributes)
- [Metadata attribute](#metadata-attribute)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although arguably the metadata attribute (singular) gives you a collection of other (not so well-known) attributes and values (plural.) So I wouldn't mind calling this section Metadata attributes if you want.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've kept the anchor unchanged

As mentioned above, I had left the anchor unchanged, so that anything referencing that part wouldn't result in a broken link... So what do we do?

- [Auth attributes](#auth-attributes)
- [Rate-limit attributes](#rate-limit-attributes)

Expand Down Expand Up @@ -396,9 +396,9 @@ The following attributes are available once the downstream connection with the A
</tbody>
</table>

## Metadata and filter state attributes
## Metadata attribute

The following attributes are related to the Envoy proxy filter chain. They include metadata exported by the proxy throughout the filters and information about the states of the filters themselves.
The following attribute is related to the Envoy proxy filter chain. They include metadata exported by the proxy throughout the filters.

<table>
<thead>
Expand All @@ -418,13 +418,6 @@ The following attributes are related to the Envoy proxy filter chain. They inclu
<td align="center"><p>✓</p></td>
<td align="center"><p>✓</p></td>
</tr>
<tr>
<td><p>filter_state</p></td>
<td><p>Map&lt;String, String&gt;</p></td>
<td><p>Mapping from a filter state name to its serialized string value</p></td>
<td align="center"><p></p></td>
<td align="center"><p>✓</p></td>
</tr>
</tbody>
</table>

Expand Down