Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow it to throw an error like a normal promise #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

franciscop
Copy link

@franciscop franciscop commented Feb 25, 2021

Right now if you expect it to throw and want to purposefully ignore it, it's impossible since the console.error() is inside the method.

This package says the method returns a promise, but it actually returns a promise that can never fail and could be empty, which goes against the normal JS workflow for promises and async/await. Right now the error gets swallowed and hidden from the devs.

So this PR allows the method to fail and the caller to handle the error as they see fit, as usual with JS promises.

Please let me know if you'd like the same for the other method.

Edit: the DIff seems all wrong, but I just removed the try/catch and removed an indentation level 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant