Allow it to throw an error like a normal promise #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you expect it to throw and want to purposefully ignore it, it's impossible since the
console.error()
is inside the method.This package says the method returns a promise, but it actually returns a promise that can never fail and could be empty, which goes against the normal JS workflow for promises and async/await. Right now the error gets swallowed and hidden from the devs.
So this PR allows the method to fail and the caller to handle the error as they see fit, as usual with JS promises.
Please let me know if you'd like the same for the other method.
Edit: the DIff seems all wrong, but I just removed the
try/catch
and removed an indentation level 🤷