Skip to content

Commit

Permalink
fix: small fixes to prepare 12.0.0
Browse files Browse the repository at this point in the history
Signed-off-by: Stefano Cappa <[email protected]>
  • Loading branch information
Ks89 committed May 31, 2024
1 parent 7756ba7 commit 87f7764
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 25 deletions.
35 changes: 19 additions & 16 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,40 +25,43 @@ Every time you'll run `npm install` inside an example's folder, you must rebuild
# B. Run main example
1. `npm start` => if everything is ok (also in browser's console), kill the process and go to the next step
2. `npm run build:main:dev`
3. `cd dist/angular-modal-gallery && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
4. `cd ../..`
3. `cd dist/angular-modal-gallery/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
4. `cd ../../..`
5. `npm run build:main:prod`
6. `cd dist/angular-modal-gallery && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
7. `cd ../..`
6. `cd dist/angular-modal-gallery/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
7. `cd ../../../../..`

# C. Run angular-cli-18 example
1. `cd examples/angular-cli-18`
2. `npm start` => if everything is ok (also in browser's console), kill the process and go to the next step
3. `npm run build:dev`
4. `cd dist/angular-cli && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
5. `cd ../..`
4. `cd dist/angular-cli/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
5. `cd ../../..`
6. `npm run build:prod`
7. `cd dist/angular-cli && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
8. `cd ../..`
7. `cd dist/angular-cli/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
8. `cd ../../../../..`

# D. Run angular-cli-material example
1. `cd examples/angular-cli-material`
2. `npm start` => if everything is ok (also in browser's console), kill the process and go to the next step
3. `npm run build:dev`
4. `cd dist/angular-cli && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
5. `cd ../..`
4. `cd dist/angular-cli/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
5. `cd ../../..`
6. `npm run build:prod`
7. `cd dist/angular-cli && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
8. `cd ../../../..`
7. `cd dist/angular-cli/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
8. `cd ../../../../..`

# E. Run universal example
1. `cd examples/universal`
2. `npm run start` => if everything is ok (also in browser's console), kill the process and go to the next step
3. `npm run build:dev`
4. `npm run serve:ssr` => if everything is ok (also in browser's console), kill the process and go to the next step
5. `npm run build:prod`
6. `npm run serve:ssr` => if everything is ok (also in browser's console), kill the process and go to the next step
7. `cd ../..`
4. `cd dist/universal/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
5. `cd ../../..`
6. `npm run build:prod`
7. `cd dist/universal/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step
8. `cd ../../..`
9. `npm run serve:ssr` => if everything is ok (also in browser's console), kill the process and go to the next step
10. `cd ../..`

# H. Create your pull request
1. **If it is ok, create your pull request specifying all the details**
Expand Down
2 changes: 1 addition & 1 deletion angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"build": {
"builder": "@angular-devkit/build-angular:application",
"options": {
"outputPath": "dist/angular-cli",
"outputPath": "dist/angular-modal-gallery",
"index": "src/index.html",
"browser": "src/main.ts",
"polyfills": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<img src="/favicon.png" alt="@ks89/angular-modal-gallery icon" width="180" height="auto"
title="@ks89/angular-modal-gallery"/>
<h1 class="project-title display-3 white">&#64;ks89/angular-modal-gallery</h1>
<p class="lead">Image gallery for Angular >=16</p>
<p class="lead">Currently v11</p>
<p class="lead">Image gallery for Angular >=18</p>
<p class="lead">Currently v12</p>
<br>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<img src="/favicon.png" alt="@ks89/angular-modal-gallery icon" width="180" height="auto"
title="@ks89/angular-modal-gallery"/>
<h1 class="project-title display-3 white">&#64;ks89/angular-modal-gallery</h1>
<p class="lead">Image gallery for Angular >=16</p>
<p class="lead">Currently v11</p>
<p class="lead">Image gallery for Angular >=18</p>
<p class="lead">Currently v12</p>
<br>
</div>
4 changes: 2 additions & 2 deletions examples/universal/src/app/intro-header/intro-header.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<img src="/favicon.png" alt="@ks89/angular-modal-gallery icon" width="180" height="auto"
title="@ks89/angular-modal-gallery"/>
<h1 class="project-title display-3 white">&#64;ks89/angular-modal-gallery</h1>
<p class="lead">Image gallery for Angular >=16</p>
<p class="lead">Currently v11</p>
<p class="lead">Image gallery for Angular >=18</p>
<p class="lead">Currently v12</p>
<br>
</div>
4 changes: 2 additions & 2 deletions src/app/intro-header/intro-header.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<img src="/favicon.png" alt="@ks89/angular-modal-gallery icon" width="180" height="auto"
title="@ks89/angular-modal-gallery"/>
<h1 class="project-title display-3 white">&#64;ks89/angular-modal-gallery</h1>
<p class="lead">Image gallery for Angular >=16</p>
<p class="lead">Currently v11</p>
<p class="lead">Image gallery for Angular >=18</p>
<p class="lead">Currently v12</p>
<br>
</div>

0 comments on commit 87f7764

Please sign in to comment.