Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement of KCallableImpl.callBy #36

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Performance improvement of KCallableImpl.callBy #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 25 additions & 29 deletions src/main/java/kotlinx/reflect/lite/impl/KCallableImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import kotlinx.reflect.lite.descriptors.*
import kotlinx.reflect.lite.descriptors.impl.*
import kotlinx.reflect.lite.jvm.*
import java.lang.reflect.*
import java.util.ArrayList
import kotlin.coroutines.*

internal abstract class KCallableImpl<out R>: KCallable<R> {
Expand Down Expand Up @@ -63,30 +62,28 @@ internal abstract class KCallableImpl<out R>: KCallable<R> {
return callDefaultMethod(args, null)
}

// Logic from: https://github.com/JetBrains/kotlin/blob/ea836fd46a1fef07d77c96f9d7e8d7807f793453/core/reflection.jvm/src/kotlin/reflect/jvm/internal/KCallableImpl.kt#L116
// Base logic from: https://github.com/JetBrains/kotlin/blob/ea836fd46a1fef07d77c96f9d7e8d7807f793453/core/reflection.jvm/src/kotlin/reflect/jvm/internal/KCallableImpl.kt#L116
private fun callDefaultMethod(args: Map<KParameter, Any?>, continuationArgument: Continuation<*>?): R {
val parameters = parameters
// TODO here we can avoid extra arguments copy by allocating an array of precise size if
// varargs are not present and win some performance
val arguments = ArrayList<Any?>(parameters.size)
var mask = 0
val masks = ArrayList<Int>(1)
var index = 0
val arguments = arrayOfNulls<Any?>(parameters.size + (if (isSuspend) 1 else 0)).apply {
if (isSuspend) {
// continuationArgument is tail of arguments
this[parameters.size] = continuationArgument
}
}
val masks = IntArray((parameters.size + Integer.SIZE - 1) / Integer.SIZE)
var valueParameterIndex = 0
var anyOptional = false

for (parameter in parameters) {
if (index != 0 && index % Integer.SIZE == 0) {
masks.add(mask)
mask = 0
}

when {
args.containsKey(parameter) -> {
arguments.add(args[parameter])
arguments[parameter.index] = args[parameter]
}
parameter.isOptional -> {
arguments.add(defaultPrimitiveValue(parameter.type.javaType))
mask = mask or (1 shl (index % Integer.SIZE))
arguments[parameter.index] = defaultPrimitiveValue(parameter.type.javaType)
val maskIndex = valueParameterIndex / Integer.SIZE
masks[maskIndex] = masks[maskIndex] or (1 shl (valueParameterIndex % Integer.SIZE))
anyOptional = true
}
parameter.isVararg -> {
Expand All @@ -98,29 +95,28 @@ internal abstract class KCallableImpl<out R>: KCallable<R> {
}

if (parameter.kind == KParameter.Kind.VALUE) {
index++
valueParameterIndex++
}
}

if (continuationArgument != null) {
arguments.add(continuationArgument)
}

if (!anyOptional) {
return call(*arguments.toTypedArray())
// The process is the same as call,
// but it is called directly to avoid the processing cost of spread operator.
@Suppress("UNCHECKED_CAST")
return descriptor.caller.call(arguments) as R
}

masks.add(mask)

val caller = descriptor.defaultCaller ?: throw KotlinReflectionInternalError("This callable does not support a default call: $descriptor")

arguments.addAll(masks)

// DefaultConstructorMarker or MethodHandle
arguments.add(null)
// +1 is argument for DefaultConstructorMarker or MethodHandle
val mergedArgs = arrayOfNulls<Any?>(arguments.size + masks.size + 1)
System.arraycopy(arguments, 0, mergedArgs, 0, arguments.size)
for (i in masks.indices) {
mergedArgs[i + arguments.size] = masks[i]
}

@Suppress("UNCHECKED_CAST")
return caller.call(arguments.toTypedArray()) as R
return caller.call(mergedArgs) as R
}

private fun extractContinuationArgument(): Type? {
Expand Down