Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in README.md #328

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

EchoEllet
Copy link

Just fixing a few typos in the README.md

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@EchoEllet
Copy link
Author

Hi @ilya-g, should this be merged or rejected?

@@ -253,7 +253,7 @@ Similar operations with date units are provided for `LocalDate` type:

Notice that, instead of the general `DateTimeUnit` and `DateTimePeriod` types, we're using their subtypes
`DateTimeUnit.DateBased` and `DatePeriod` respectively. This allows preventing the situations when
time components are being added to a date at compile time.
time components are being added to date at compile time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a date" here means "an instance of LocalDate type"

@@ -318,7 +318,7 @@ repositories {
}
```

- In multiplatform projects, add a dependency to the commonMain source set dependencies
- In multiplatform projects, add a dependency to the `commonMain` source set of dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the dependencies DSL block of a source set, not a set of dependencies.

@@ -391,7 +391,7 @@ git submodule update
```

The project requires JDK 8 to build classes and to run tests.
Gradle will try to find it among the installed JDKs or [provision](https://docs.gradle.org/current/userguide/toolchains.html#sec:provisioning) it automatically if it couldn't be found.
Gradle will try to find it among the installed JDKs or [provision](https://docs.gradle.org/current/userguide/toolchains.html#sec:provisioning) automatically if it can't be found.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to reword as "[download] it automatically"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants