Use Worker API for Benchmark generators #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
force-pushed
the
adam/feat/use-worker-api
branch
7 times, most recently
from
e5f0f46 to
70c4cab
Compare
- Update the Benchmark JS/Wasm/Native source generation tasks to use the Worker API, so that `kotlin-compiler-embeddable` can be a compileOnly dependency, thus resolving https://youtrack.jetbrains.com/issue/KT-66764 - Create `GenerateJsSourceWorker` and `GenerateWasmSourceWorker` for isolating the JS and Wasm generation code. - Updated the Js/Wasm/Native generation tasks to invoke the source generators in a Worker isolated classpath. - Created a new Configuration for declaring `kotlin-compiler-embeddable`, and pass it to the Js/Wasm/Native generation tasks. - Create a BenchmarkDependencies utility for defining all Configurations used in the plugin. (This also lays the groundwork for unifying the JMH version #147 (comment)) - Updated BenchmarksPluginConstants to add `DEFAULT_KOTLIN_COMPILER_VERSION`, as sensible default for kotlin-compiler-embeddable. - Add opt-in annotation RequiresKotlinCompilerEmbeddable to highlight code that requires `kotlin-compiler-embeddable` - Some classes were updated to be `abstract`, to follow Gradle best practices for creating managed objects. This commit also contains formatting changes, as the code style is not consistent.
adam-enko
force-pushed
the
adam/feat/use-worker-api
branch
from
70c4cab to
279d309
Compare
fzhinkin
requested changes
Jul 9, 2024
plugin/main/src/kotlinx/benchmark/gradle/JmhBytecodeGeneratorWorker.kt
Outdated
Show resolved
Hide resolved
plugin/main/src/kotlinx/benchmark/gradle/internal/BenchmarkDependencies.kt
Show resolved
Hide resolved
plugin/main/src/kotlinx/benchmark/gradle/internal/generator/workers/GenerateJsSourceWorker.kt
Show resolved
Hide resolved
fzhinkin
reviewed
Jul 9, 2024
plugin/main/src/kotlinx/benchmark/gradle/internal/BenchmarkDependencies.kt
Outdated
Show resolved
Hide resolved
|
Everything looks good to me; only need to revamp kotlinx-benchmark's CI before merging. |
|
@adam-enko please update the branch with the latest changes from |
Done! Will the PR be blocked because your last GitHub review is 'requested changes'? |
fzhinkin
approved these changes
Jul 10, 2024
kx412764776
pushed a commit
to kx412764776/kotlinx-benchmark
that referenced
this pull request
Jul 11, 2024
* Use Worker API to generate benchmark code - Update the Benchmark JS/Wasm/Native source generation tasks to use the Worker API, so that `kotlin-compiler-embeddable` can be a compileOnly dependency, thus resolving https://youtrack.jetbrains.com/issue/KT-66764 - Create `GenerateJsSourceWorker` and `GenerateWasmSourceWorker` for isolating the JS and Wasm generation code. - Updated the Js/Wasm/Native generation tasks to invoke the source generators in a Worker isolated classpath. - Created a new Configuration for declaring `kotlin-compiler-embeddable`, and pass it to the Js/Wasm/Native generation tasks. - Create a BenchmarkDependencies utility for defining all Configurations used in the plugin. (This also lays the groundwork for unifying the JMH version Kotlin#147 (comment)) - Updated BenchmarksPluginConstants to add `DEFAULT_KOTLIN_COMPILER_VERSION`, as sensible default for kotlin-compiler-embeddable. - Add opt-in annotation RequiresKotlinCompilerEmbeddable to highlight code that requires `kotlin-compiler-embeddable` - Some classes were updated to be `abstract`, to follow Gradle best practices for creating managed objects. This commit also contains formatting changes, as the code style is not consistent. * Replace `Kotlinx Benchmark` with `kotlinx-benchmark` in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Worker API to generate benchmark code
kotlin-compiler-embeddablecan be a compileOnly dependency, thus resolving https://youtrack.jetbrains.com/issue/KT-66764GenerateJsSourceWorkerandGenerateWasmSourceWorkerfor isolating the JS and Wasm generation code.kotlin-compiler-embeddable, and pass it to the Js/Wasm/Native generation tasks.DEFAULT_KOTLIN_COMPILER_VERSION, as sensible default for kotlin-compiler-embeddable.kotlin-compiler-embeddableabstract, to follow Gradle best practices for creating managed objects.I have tested this manually by running the Gradle Plugin tests with Kotlin version set to 2.0. However, Benchmarks is not compatible with KGP 2.0 as a KGP function has changed #236. If I comment out this changed function, then Benchmarks works as expected.