Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task-selector workaround to use task rules #3477

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adam-enko
Copy link
Member

@adam-enko adam-enko commented Jan 29, 2024

Update the workaround for gradle/gradle#22335 to use task rules.

Discussed here.

Goals

  • It should be more clear how to add/link tasks.
  • Tasks should be easier to use, understand, run.
  • tasks should follow conventions (specifically: check runs all verifications, test runs JVM verifications, integrationTest runs all integration tests)

Details

  • Create task rules for propagating tasks:

    • includedBuildTasks_<TASK> → runs in included builds
    • subprojectTasks_<TASK> → runs in subprojects (this shouldn't be invoked manually, only in by the includedBuildTasks_ rule, otherwise it creates cyclical task dependencies).
  • Update tasks:

    • check runs all validations
    • test runs apiCheck
    • introduce 'publishAllPublicationsToRemoteRepositories' lifecycle task

- Workaround for gradle/gradle#22335
- Update tasks:
  - check runs all validations
  - test runs apiCheck
  - introduce 'publishAllPublicationsToRemoteRepositories' lifecycle task
@adam-enko adam-enko force-pushed the feat/included-build-task-dependencies branch from c39aa37 to 7fdc28b Compare January 29, 2024 11:25
@adam-enko adam-enko self-assigned this Feb 2, 2024
@adam-enko adam-enko added the infrastructure Everything related to builds tools, CI configurations and project tooling label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Everything related to builds tools, CI configurations and project tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant