GeoDataFrame init #909
GeoDataFrame init #909
Conversation
| implementation(libs.ktor.serialization.kotlinx.json) | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Is it still required to be a friend module?
| import org.jetbrains.kotlinx.dataframe.api.with | ||
|
|
||
| class GeoDataFrame<T : GeoFrame>(val df: DataFrame<T>, val crs: CoordinateReferenceSystem?) { | ||
| fun update(updateBlock: DataFrame<T>.() -> DataFrame<T>): GeoDataFrame<T> { |
There was a problem hiding this comment.
Did you consider other names? Like
updateDfreplaceDf(more consistent with what replace does in DF compared to update)
| return GeoDataFrame(df.updateBlock(), crs) | ||
| } | ||
|
|
||
| fun applyCRS(targetCRS: CoordinateReferenceSystem? = null): GeoDataFrame<T> { |
There was a problem hiding this comment.
Proper camel casing would be "applyCrs" and "targetCrs"
| with(libs.plugins) { | ||
| alias(kotlin.jvm) | ||
| alias(publisher) | ||
| alias(jupyter.api) |
There was a problem hiding this comment.
Could you include ktlint too?
|
|
||
| object Geocoder { | ||
|
|
||
| private val url = "https://geo2.datalore.jetbrains.com/map_data/geocoding" |
There was a problem hiding this comment.
Should this be included in the stock library? As far as I remember this was a reverse engineering endeavour and since it depends on an external URL behaviour might change or stop working entirely
| @@ -41,3 +41,4 @@ plugins { | |||
| } | |||
| include("dataframe-excel") | |||
| include("core") | |||
| include("dataframe-geo") | |||
There was a problem hiding this comment.
if you want dataframe-geo to be imported by default when users depend on the generic dataframe package, also add dataframe-geo in build.gradle.kts
| return execute(codeWithConverter, variableName) | ||
| } | ||
|
|
||
| override fun Builder.onLoaded() { |
There was a problem hiding this comment.
what does this jupyter integration do exactly? could you add some docs?
| import java.net.URL | ||
|
|
||
|
|
||
| fun GeoDataFrame.Companion.readGeoJSON(path: String): GeoDataFrame<*> { |
There was a problem hiding this comment.
readGeoJson is proper camel casing
| typeBuilder.name = name ?: "geodata" | ||
| typeBuilder.setCRS(crs) | ||
| val geometryClass = if (singleGeometryType) { | ||
| // todo singleOrNull() ?: error() |
| import org.jetbrains.kotlinx.dataframe.geo.GeoFrame | ||
| import org.locationtech.jts.geom.Geometry | ||
|
|
||
| fun SimpleFeatureCollection.toGeoDataFrame(): GeoDataFrame<*> { |
There was a problem hiding this comment.
please rename the file to "toGeoDataFrame" like you did with the other file
No description provided.