Skip to content

Commit

Permalink
fixup! Fixed one failing test for #713: convertTo can create a tempor…
Browse files Browse the repository at this point in the history
…ary non-nullable column with nulls in it. This is now avoided and the behavior has been simplified/stabilized
  • Loading branch information
Jolanrensen committed Jul 30, 2024
1 parent 46e1017 commit 5e01d86
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,8 @@ internal fun AnyFrame.convertToImpl(

dsl.fillers.forEach { filler ->
val paths = result.getColumnPaths(UnresolvedColumnsPolicy.Create, filler.columns).toSet()
missingPaths -= paths
val (newPaths, existingPaths) = paths.partition { it in missingPaths }
missingPaths -= paths

// first fill cols that are already in the df
result = result.update { existingPaths.toColumnSet() }.with { filler.expr(this, this) }
Expand Down

0 comments on commit 5e01d86

Please sign in to comment.