Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Support MSSQL named instances #300

Merged
merged 7 commits into from
Oct 28, 2020
Merged

Support MSSQL named instances #300

merged 7 commits into from
Oct 28, 2020

Conversation

Ricki-BumbleDev
Copy link
Contributor

Addresses #264

@Kononnable
Copy link
Owner

Sorry for delay, I haven't spent much time on this project lately.
I didn't use mssql for a while now, but as I recall with named instance there is no need for port number. Names were used to replace port numbers.
Am I correct or is port number required when connecting to named instance(e.g. points to service which translates instance names to correct ip addresses/ports)?

@Ricki-BumbleDev
Copy link
Contributor Author

Ricki-BumbleDev commented Oct 26, 2020

Hey, no worries, we all are busy.

Am I correct or is port number required when connecting to named instance(e.g. points to service which translates instance names to correct ip addresses/ports)?

AFAIK the latter is the case. The port is indeed for that service translating the instance name you mentioned. Default port is 1433, but I'm sure that could be changed.

@Kononnable
Copy link
Owner

Looked through the docs for instanceName:
The instance name to connect to. The SQL Server Browser service must be running on the database server, and UDP port 1444 on the database server must be reachable. (no default) Mutually exclusive with options.port.
Didn't find any option for defining port to connect to SQL Server Browser, so it looks like it just ignores port value.

Moved asking for instance name and hided port selection if instance name is specified. Could you check if you can connect to named instance as expected? I don't have any windows machine atm.
In any case, I'll merge this PR later this week. Thanks for your work.

@Ricki-BumbleDev
Copy link
Contributor Author

LGTM, still works

@Kononnable Kononnable merged commit 1d60414 into Kononnable:master Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants