This repository has been archived by the owner on Oct 10, 2022. It is now read-only.
Abstract class generation #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivawzh
force-pushed
the
inherit-custom-abstract-class
branch
3 times, most recently
from
a75d1c5 to
2359ee6
Compare
ivawzh
force-pushed
the
inherit-custom-abstract-class
branch
from
2359ee6 to
b2ebeb2
Compare
The idea is to use the generated classes as abstract classes. Custom domain behaviors (i.e. methods, validations, and lifecycles) may be located in another class that inherits the generated model. This could benefit us from 1. avoiding polluting when running codegen after migration on existing codes. 1. have lean models without the boilerplates. 1. share common behaviors across multiple models. 3 new flags: - `extendAbstractClass` - string. Similar to `activeRecord` that `extends BaseEntity`. Now it supports custom abstract class inheritance by passing a relative path as string to `extendAbstractClass`. - `exportAbstractClass` - boolean. Export the generated models as an abstract class without `@Entity` - `skipRelationships` - boolean. Skip generating relationship columns. Because currently there is a [bug from TypeORM failing at foreign key embedded columns in abstract classes](typeorm/typeorm#3132). Close: Kononnable#288
ivawzh
force-pushed
the
inherit-custom-abstract-class
branch
from
b2ebeb2 to
894b641
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
As I recall this was never a full feathered PR, only a draft. Shame, that GH doesn't show it anywhere here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support abstract class codegen.
The idea is to use the generated classes as abstract classes. Custom domain behaviors (i.e. methods, validations, and lifecycles) may be located in another class that inherits the generated model. This could benefit us from
3 new flags:
extendAbstractClass- string. Similar toactiveRecordthatextends BaseEntity. Now it supports custom abstract class inheritance by passing a relative path as string toextendAbstractClass.exportAbstractClass- boolean. Export the generated models as an abstract class without@EntityskipRelationships- boolean. Skip generating relationship columns. Because currently there is a bug from TypeORM failing at foreign key embedded columns in abstract classes. Plus, too often we will need to rename the relationships anyway.Close: #288