-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue - 3713] Extension - Fix bug validating recipient balance when sending Substrate token #3771
base: subwallet-dev
Are you sure you want to change the base?
Conversation
🚀 Deployed on https://pr-3771--sw-web-runner.netlify.app |
@@ -189,7 +190,7 @@ export class BalanceService implements StoppableServiceInterface { | |||
} | |||
|
|||
/** Subscribe token free balance of an address on chain */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update
@@ -189,7 +190,7 @@ export class BalanceService implements StoppableServiceInterface { | |||
} | |||
|
|||
/** Subscribe token free balance of an address on chain */ | |||
public async subscribeTransferableBalance (address: string, chain: string, tokenSlug: string | undefined, extrinsicType?: ExtrinsicType, callback?: (rs: AmountData) => void): Promise<[() => void, AmountData]> { | |||
public async subscribeBalance (address: string, chain: string, tokenSlug: string | undefined, balanceType: 'transferable' | 'total', extrinsicType?: ExtrinsicType, callback?: (rs: AmountData) => void): Promise<[() => void, AmountData]> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should better create BalanceType Enum
@@ -1652,6 +1654,10 @@ export default class KoniExtension { | |||
return await this.#koniState.balanceService.getTransferableBalance(address, networkKey, token, extrinsicType); | |||
} | |||
|
|||
private async getAddressTotalBalance ({ address, extrinsicType, networkKey, token }: RequestFreeBalance): Promise<AmountData> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recheck with _MANTA_ZK_CHAIN_GROUP case
No description provided.