Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check for empty changes before trying to commit #81

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

andrewwylde
Copy link
Contributor

I think that this should prevent errors on empty commits, and also not commit an empty commit when we don't need to. I wasn't 100% confident whether we'd need the GH_TOKEN or user information for gh pr, but I wanted to make the smallest change I could.

@andrewwylde andrewwylde added the skip-release Preserve the current version when merged label Jan 31, 2024
@andrewwylde andrewwylde requested review from mheap and 425devon January 31, 2024 15:37
@andrewwylde andrewwylde force-pushed the ci/check-empty-changes branch from 95ef9ab to 5ce99fa Compare January 31, 2024 15:37
Copy link
Contributor

@Mierenga Mierenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewwylde andrewwylde merged commit 4a967cd into main Jan 31, 2024
6 checks passed
@andrewwylde andrewwylde deleted the ci/check-empty-changes branch January 31, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants