Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(expressions): better language support #1895

Merged
merged 9 commits into from
Jan 20, 2025
Merged

feat(expressions): better language support #1895

merged 9 commits into from
Jan 20, 2025

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Jan 15, 2025 •
edited
Loading

Summary

This pull request:

  • Fixes the tokenization rules to improve the syntax highlighting for the Expressions language
  • Supports simple token-based autocompletion that provides information on LHS and RHS

Better syntax highlighting

Syntax highlighting
Before Screenshot 2025-01-15 at 15 09 03
After Screenshot 2025-01-15 at 14 57 06

Better autocompletion

Screen.Recording.2025-01-15.at.14.58.40.mov

KM-900

@sumimakito sumimakito force-pushed the feat/expressions-better-language-support branch 3 times, most recently from e18b27e to 0b36824 Compare January 16, 2025 03:31
@sumimakito sumimakito marked this pull request as ready for review January 16, 2025 06:07
@sumimakito sumimakito requested a review from a team as a code owner January 16, 2025 06:07
@sumimakito sumimakito force-pushed the feat/expressions-better-language-support branch from 54fcd04 to eca10b8 Compare January 20, 2025 02:35
@sumimakito sumimakito enabled auto-merge (squash) January 20, 2025 03:30
Leopoldthecoder
Leopoldthecoder approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and LGTM

@Leopoldthecoder Leopoldthecoder merged commit f36e911 into main Jan 20, 2025
10 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/expressions-better-language-support branch January 20, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumimakito @Leopoldthecoder