Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): overall and per-span latency display #1871

Merged
merged 8 commits into from
Dec 26, 2024
Merged

fix(tracing): overall and per-span latency display #1871

merged 8 commits into from
Dec 26, 2024

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Dec 23, 2024 •
edited
Loading

Summary

  • Updates the overall and per-span latency display
    Screenshot 2024-12-23 at 19 55 33
  • Exported span attributed were updated and aligned with Gateway
  • Legend colors were removed to avoid confusion
  • Will round-up and format latencies in milliseconds with one decimal place

KM-822 + KM-838

@sumimakito sumimakito marked this pull request as ready for review December 24, 2024 09:30
@sumimakito sumimakito requested review from a team as code owners December 24, 2024 09:30
@sumimakito sumimakito marked this pull request as draft December 25, 2024 02:39
Leopoldthecoder
Leopoldthecoder approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumimakito sumimakito marked this pull request as ready for review December 26, 2024 06:15
@sumimakito sumimakito merged commit 0b418a4 into main Dec 26, 2024
9 checks passed
@sumimakito sumimakito deleted the fix/tracing-latency branch December 26, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumimakito @Leopoldthecoder