Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): incorrect span bar position and undefined access error #1859

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

sumimakito
Copy link
Member

Summary

This pull request corrects the position calculation of span bars and fixes the Cannot read properties of undefined (reading 'x') error.

This pull request also contains misc bug fixes and clean-ups.

KM-823

@sumimakito sumimakito requested review from a team as code owners December 18, 2024 10:22
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumimakito sumimakito merged commit 6bc2d67 into main Dec 18, 2024
9 checks passed
@sumimakito sumimakito deleted the fix/tracing-various-bugs branch December 18, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants