Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filtering for country code #1843

Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat: add filtering for country code #1843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4ee673
feat: add filtering for country code
alxgrant Dec 9, 2024
f7be8e8
feat: add explore support
alxgrant Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/analytics/analytics-utilities/src/types/explore/advanced.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export const queryableExploreDimensions = [
...queryableBasicExploreDimensions,
'application',
'consumer',
'country_code',
'iso_code',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check: is iso_code going to go away? I'm not up to date on the status.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will, but right now it is still being used by the front end in both explore and api requests. I've updated the FE ticket to include a comment to remove iso_code in favor of country_code when updating the filtering. After that we can remove. https://konghq.atlassian.net/browse/MA-3448

] as const

Expand Down
1 change: 1 addition & 0 deletions packages/analytics/analytics-utilities/src/types/explore/requests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export type FilterableRequestDimensions = typeof filterableRequestDimensions[num
export const queryableRequestWildcardDimensions = [
'auth_type',
'client_ip',
'country_code',
'data_plane_node_version',
'header_host',
'header_user_agent',
Expand Down
Loading