Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboards): preserve granularity in explore link #1839

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix(dashboards): preserve granularity in explore link #1839

merged 1 commit into from
Dec 6, 2024

Conversation

filipgutica
Copy link
Contributor

@filipgutica filipgutica commented Dec 6, 2024 •
edited
Loading

Summary

  • If granularity is provided through the tile definition use that. Otherwise, fallback to the granularity which was determined and used at query time, which is available in the meta of the explore result.

https://konghq.atlassian.net/browse/MA-3488

@filipgutica filipgutica requested a review from a team as a code owner December 6, 2024 16:19
@filipgutica filipgutica force-pushed the fix/maintain-granularity-on-go-to-explore branch from 775f63e to 25b1468 Compare December 6, 2024 16:26
adorack
adorack approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@adorack adorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, though I also think it's getting to the point where unit tests would be helpful. I'd recommend adding them now; I'd probably push harder for them the next time we need to touch this code.

@filipgutica filipgutica merged commit 10603de into main Dec 6, 2024
9 checks passed
@filipgutica filipgutica deleted the fix/maintain-granularity-on-go-to-explore branch December 6, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adorack adorack adorack approved these changes

@mihai-peteu mihai-peteu Awaiting requested review from mihai-peteu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipgutica @adorack