fix(*): proper heading element in widgets [KHCP-11027] #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portikM
requested review from
kongponents-bot,
a team,
adamdehaven and
jillztom
as code owners
adamdehaven
reviewed
Mar 18, 2024
packages/analytics/analytics-chart/src/components/TopNTable.vue
Outdated
Show resolved
Hide resolved
mihai-peteu
approved these changes
Mar 20, 2024
adamdehaven
approved these changes
Mar 20, 2024
adorack
requested changes
Mar 20, 2024
| @@ -183,6 +186,10 @@ const props = defineProps({ | |||
| required: false, | |||
| default: () => 'lg', | |||
| }, | |||
| titleTag: { | |||
There was a problem hiding this comment.
Could you explain more about the use case behind making this a property? I'd expect we'd want all metric cards to have the same title tag...
There was a problem hiding this comment.
That is the case most of the time, however if metrics card is seeded inside some other widget that already has an h2 heading - it should be h3 to not break the hierarchy - that's when this prop comes in handy. Regardless of what tag is used - styling for the title remains consistent though
adorack
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-11027
Update title in widget-like components to come with appropriate heading element
Applied fixed can be found in PRs picking up new versions of published packages:
Resources