Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics-chart): experimenting with legend styling #1240

Closed
wants to merge 14 commits into from

Conversation

mihai-peteu
Copy link
Contributor

@mihai-peteu mihai-peteu commented Mar 13, 2024

Summary

@filipgutica This is an attempt to simplify the Legend height conundrum, and keep it styled via pure CSS (thus allowing us to do away with the bound CSS variable).

Using color squares instead of lines, and also left-aligning the legend (roughly in line w/ the Y-Axis labels)
Screenshot 2024-03-19 at 11 36 51

Resources

@mihai-peteu mihai-peteu marked this pull request as ready for review March 19, 2024 18:38
@mihai-peteu mihai-peteu requested a review from a team as a code owner March 19, 2024 18:38
Copy link
Contributor

@filipgutica filipgutica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes still overlapping in some situations and also sometimes not showing the second row

image

image

Also, when it wraps to a new line, should there be more space between rows?
image

@mihai-peteu mihai-peteu requested a review from filipgutica April 8, 2024 22:40
Copy link
Contributor

@filipgutica filipgutica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still some weirdness with the spacing of the legend items, some legend color tags also don't show up or are getting cut off?

On this branch
image

Vs on dev:
image

@mihai-peteu
Copy link
Contributor Author

Closing in favor of #1462

But the legendAsGrid mixin could prove useful in the future...

@mihai-peteu mihai-peteu deleted the feat/legend-experiments branch June 24, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants