fix(analytics-chart): chart height, legend padding, y-axis hover [MA-2536] #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihai-peteu
changed the title
mihai-peteu
commented
Feb 22, 2024
packages/analytics/analytics-chart/src/components/AnalyticsChart.vue
Outdated
Show resolved
Hide resolved
mihai-peteu
commented
Feb 22, 2024
| @@ -212,7 +212,7 @@ const axesTooltip = ref<AxesTooltipState>({ | |||
| top: '0px', | |||
| left: '0px', | |||
| text: '', | |||
| offset: 0, | |||
| offset: -50, // Avoids App Shell obstruction | |||
There was a problem hiding this comment.
This is for the app shell overlap fix, it essentially translates the Y-axis tooltip 50px to the right:
https://kongstrong.slack.com/archives/C01RF6STU2F/p1708592869580189
mihai-peteu
changed the title
mihai-peteu
force-pushed
the
fix/ma-2536-chart-padding-yaxis-hover
branch
from
caad789 to
07f0cdb
Compare
filipgutica
requested changes
Feb 24, 2024
packages/analytics/dashboard-renderer/src/components/BarChartRenderer.vue
Show resolved
Hide resolved
packages/analytics/dashboard-renderer/src/components/TimeseriesChartRenderer.vue
Show resolved
Hide resolved
filipgutica
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/MA-2536