fix(proxy-wasm) catch get/set all scoped properties outside of requests #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
===================================================
+ Coverage 90.29307% 90.81210% +0.51903%
===================================================
Files 53 53
Lines 11260 11341 +81
Branches 1597 1690 +93
===================================================
+ Hits 10167 10299 +132
+ Misses 1087 1036 -51
Partials 6 6
... and 14 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
thibaultcha
force-pushed
the
fix/scoped-properties
branch
6 times, most recently
from
6f8ae21 to
205f3a8
Compare
Scoped properties (e.g. `request.*`, `response.*`, `upstream.*`, ...) can only be read/written from within the context of a request. Only non-scoped properties (e.g. `worker_id`) can be accessed from root contexts. Prior to this commit, only `ngx.*` and `wasmx.*` (host) properties were caught. Other scoped properties that did not map to either of those would cause a segfault. We now catch all scoped properties (i.e. containing a `.` character) when getting/setting properties outside of a request.
Some tests resolving to external services were unreliable as they were using a real resolver instead of the local dnsmasq mock resolver that we use on CI.
thibaultcha
force-pushed
the
fix/scoped-properties
branch
from
205f3a8 to
3b009cd
Compare
|
I believe this patch is incorrect as for example the variable |
|
Nice catch thanks - the patch is fine, it's a different issue for |
|
See #667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoped properties (e.g.
request.*,response.*,upstream.*, ...) can only be read/written from within the context of a request. Only non-scoped properties (e.g.worker_id) can be accessed from root contexts.Prior to this commit, only
ngx.*andwasmx.*(host) properties were caught. Other scoped properties that did not map to either of those would cause a segfault.We now catch all scoped properties (i.e. containing a
.character) when getting/setting properties outside of a request.