-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(*) increase robustness of httpbin-reliant tests #629
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
=============================================
Coverage 90.86064% 90.86064%
=============================================
Files 52 52
Lines 11259 11259
=============================================
Hits 10230 10230
Misses 1029 1029
Flags with carried forward coverage won't be shown. Click here to find out more. |
Weird. The 503 would have come from the local httpbin instance that runs during CI, not the real one hosted at httpbin.org, which is unexpected. |
Sure, but the test is still considered successful. |
bf2887d
to
e918992
Compare
We sometimes get a real 503 from httpbin.org as well. The tests still succeed in case of upstream errors.
e918992
to
e175b8c
Compare
In fact the error probably comes from our Nginx proxy in front. But again, we already expect this as per the test cases, this PR is not introducing anything new. |
The setup of the failing run has a strange "setup local httpbin server" step in which we see:
It looks like it is missing the We can investigate it a bit. That said, iirc these special 5xx handling in these tests were there even before we had a local httpbin setup as httpbin.org was really giving us some 500s from time to time. |
Actually the output is not anomalous, the |
We sometimes get a real 503 from httpbin.org as well. The tests still succeed in case of upstream errors.