Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy-wasm) set querystring when setting ":path" #627

Closed
wants to merge 4 commits into from

Conversation

hishamhm
Copy link
Contributor

...to clarify that it matches `":path"` (that is, path including
querystring), making the field name match the pseudo-header, as
is the case with the other entries in `ngx_http_proxy_wasm_dispatch_s`.
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82724%. Comparing base (9238d4a) to head (f22115b).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #627         +/-   ##
===================================================
- Coverage   90.84180%   90.82724%   -0.01457%     
===================================================
  Files             52          52                 
  Lines          11214       11218          +4     
===================================================
+ Hits           10187       10189          +2     
- Misses          1027        1029          +2     
Files with missing lines Coverage Δ
src/common/proxy_wasm/ngx_proxy_wasm_maps.c 93.54839% <100.00000%> (+0.07012%) ⬆️
src/http/proxy_wasm/ngx_http_proxy_wasm_dispatch.c 91.68704% <100.00000%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
unit 90.58310% <100.00000%> (+0.00287%) ⬆️
valgrind 82.41920% <76.92308%> (-0.08938%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

… passed through.

This matches the plain Nginx behavior, and showcased in one of the tests.



=== TEST 17: proxy_wasm - showcase that that path with invalid querystring passes through
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to make tests 16 and 17 into a single test using --- request eval and ["GET /set_by_proxy_wasm", "GET /raw_nginx"]. That worked in isolation, but it messed up the plan_tests count.

@thibaultcha thibaultcha added the pr/merge-in-progress PR: Merge in progress (do not push) label Nov 23, 2024
@thibaultcha
Copy link
Member

Merged!

@thibaultcha thibaultcha deleted the feat/set-query branch November 23, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/merge-in-progress PR: Merge in progress (do not push)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants