misc(*) remove from ngx_wasm_lua_resolver_resolve call freeing 'rslv_ctx'
#624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
===================================================
- Coverage 90.84180% 90.83289% -0.00892%
===================================================
Files 52 52
Lines 11214 11214
===================================================
- Hits 10187 10186 -1
- Misses 1027 1028 +1
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
…v_ctx' Presently the behavior of `ngx_wasm_lua_resolver_resolve` mimics the one from ngx_resolve_name, which frees its argument 'rslv_ctx' in case of any errors. This commit changes `ngx_wasm_lua_resolver_resolve` to not free 'rslv_ctx' if any errors occur, delegating the responsibility to its caller. Although it makes `ngx_wasm_lua_resolver_resolve` less consistent with ngx_resolve_name, this change allows the upcoming logic exposing `ngx_wasm_lua_resolver_resolve` as a PW foreign-function to allocate 'rslv_ctx' using memory from the pwexec's pool, instead of from malloc.
casimiro
force-pushed
the
misc/lua_resolver
branch
from
1a324d6 to
e5d249d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently the behavior of
ngx_wasm_lua_resolver_resolvemimics the one fromngx_resolve_name, which frees its argument 'rslv_ctx' in case of any errors.This commit changes
ngx_wasm_lua_resolver_resolveto not free 'rslv_ctx' if any errors occur, delegating the responsibility to its caller.Although it makes
ngx_wasm_lua_resolver_resolveless consistent withngx_resolve_name, this change allows the upcoming logic exposingngx_wasm_lua_resolver_resolveas a PW foreign-function to allocate 'rslv_ctx' using memory from the pwexec's pool, instead of from malloc.