fix(ffi) correct usage of 'n_bins' when parsing a histogram #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when parsing a histogram without uninitialized bins, `parse_cmetric` would incorrectly build an extra bin from invalid memory. Histograms with uninitialized bins were correctly parsed due to `parse_cmetric` stop parsing bins when an uninitialized one is found.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
===================================================
+ Coverage 90.72770% 90.73673% +0.00902%
===================================================
Files 52 52
Lines 11076 11076
===================================================
+ Hits 10049 10050 +1
+ Misses 1027 1026 -1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when parsing a histogram without uninitialized bins,
parse_cmetricwould incorrectly build an extra bin from invalid memory.Histograms with uninitialized bins were correctly parsed due to
parse_cmetricstop parsing bins when an uninitialized one is found.