Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*) generalize bytes readers for all ngx_wa #597

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

thibaultcha
Copy link
Member

These will be used in IPC code.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71783%. Comparing base (80da044) to head (d5235b0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #597         +/-   ##
===================================================
- Coverage   90.72686%   90.71783%   -0.00903%     
===================================================
  Files             51          52          +1     
  Lines          11075       11075                 
===================================================
- Hits           10048       10047          -1     
- Misses          1027        1028          +1     
Files with missing lines Coverage Δ
src/common/ngx_wa_readers.c 100.00000% <100.00000%> (ø)
src/common/ngx_wasm_socket_tcp_readers.c 87.61062% <100.00000%> (-0.20451%) ⬇️

... and 2 files with indirect coverage changes

Flag Coverage Δ
unit 90.44625% <100.00000%> (ø)
valgrind 82.28991% <100.00000%> (-0.06945%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@thibaultcha thibaultcha force-pushed the refactor/generalize-readers branch from 258ff54 to d5235b0 Compare October 3, 2024 01:08
@thibaultcha thibaultcha merged commit a365850 into main Oct 3, 2024
32 checks passed
@thibaultcha thibaultcha deleted the refactor/generalize-readers branch October 3, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant