Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) isolate test suites by Wasm target #594

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

thibaultcha
Copy link
Member

  • Remove WASI spillover from test crates compatible with the wasm32-unknown-unknown target.
  • Default all tests crates to compile wasm32-wasip1 targets.
  • Can set TEST_NGINX_CARGO_RUSTTARGET to override.
  • Cleanup build tests framework.
  • CI: add a job with wasm32-unknown-unknown target.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56826%. Comparing base (f8d79ee) to head (5e5befa).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #594         +/-   ##
===================================================
- Coverage   90.69725%   90.56826%   -0.12900%     
===================================================
  Files             51          51                 
  Lines          11072       11016         -56     
===================================================
- Hits           10042        9977         -65     
- Misses          1030        1039          +9     
Files with missing lines Coverage Δ
src/wasm/wasi/ngx_wasi_preview1_host.c 78.08219% <ø> (ø)
src/wasm/wrt/ngx_wrt_v8.c 88.84758% <ø> (ø)
src/wasm/wrt/ngx_wrt_wasmer.c 81.86398% <ø> (+0.18459%) ⬆️
src/wasm/wrt/ngx_wrt_wasmtime.c 82.83828% <100.00000%> (+0.26946%) ⬆️

... and 31 files with indirect coverage changes

Flag Coverage Δ
unit 90.48204% <100.00000%> (+0.06967%) ⬆️
valgrind 81.26431% <ø> (-1.08981%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

* Remove WASI spillover from test crates compatible with the
  `wasm32-unknown-unknown` target.
* Default all tests crates to compile `wasm32-wasip1` targets.
* Can set `TEST_NGINX_CARGO_RUSTTARGET` to override.
* Cleanup build tests framework.
* CI: add a job with `wasm32-unknown-unknown` target.
@thibaultcha thibaultcha merged commit 35e8eb7 into main Sep 26, 2024
32 checks passed
@thibaultcha thibaultcha deleted the chore/wasm-targets branch September 26, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant