Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) move CodeQL analysis to its own recurring workflow #550

Merged
merged 1 commit into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .github/workflows/ci-large.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,21 +130,6 @@ jobs:
ssl: ${{ matrix.ssl }}
debug: ${{ matrix.debug }}

codeql:
name: 'CodeQL analyzer'
#timeout-minutes: see job-codeql-analyzer.yml
strategy:
fail-fast: false
matrix:
language: ["c-cpp"]
openresty: [1.25.3.1]
runtime: [wasmtime, wasmer, v8]
uses: ./.github/workflows/job-codeql-analyzer.yml
with:
language: ${{ matrix.language }}
openresty: ${{ matrix.openresty }}
runtime: ${{ matrix.runtime }}

build:
name: 'Build'
#if: ${{ false }}
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -303,21 +303,6 @@ jobs:
ssl: ${{ matrix.ssl }}
debug: ${{ matrix.debug }}

codeql:
name: 'CodeQL analyzer'
#timeout-minutes: see job-codeql-analyzer.yml
strategy:
fail-fast: false
matrix:
language: ["c-cpp"]
openresty: [1.25.3.1]
runtime: [wasmtime, wasmer, v8]
uses: ./.github/workflows/job-codeql-analyzer.yml
with:
language: ${{ matrix.language }}
openresty: ${{ matrix.openresty }}
runtime: ${{ matrix.runtime }}

build:
name: 'Build'
#if: ${{ false }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,28 +1,20 @@
name: CodeQL

on:
workflow_call:
inputs:
language:
required: true
type: string
openresty:
required: true
type: string
runtime:
required: true
type: string
push:
branches: main
paths-ignore:
- '**/*.md'
- '**/release.yml'
- '**/ci-large.yml'
- 'assets/release/Dockerfiles/*'
#pull_request:
#branches: '**'

defaults:
run:
shell: bash

env:
NGX_BUILD_OPENRESTY: ${{ inputs.openresty }}
NGX_BUILD_DEBUG: 1
NGX_BUILD_SSL: 1
NGX_BUILD_DYNAMIC_MODULE: 1

jobs:
codeql:
name: 'CodeQL analyzer'
Expand All @@ -32,14 +24,20 @@ jobs:
actions: read
contents: read
security-events: write
outputs:
sarif_file: ${{ steps.sarif-filename.outputs.name }}
strategy:
fail-fast: false
matrix:
include:
- language: c-cpp
build-mode: manual
openresty: 1.25.3.1
runtime: v8 # v8bridge
steps:
- uses: actions/checkout@v4
- name: Setup CodeQL
uses: github/codeql-action/init@v3
with:
languages: ${{ inputs.language }}
languages: ${{ matrix.language }}
- name: 'Setup cache - work/ dir'
uses: actions/cache@v4
if: ${{ !env.ACT }}
Expand All @@ -48,22 +46,28 @@ jobs:
work/downloads
work/runtimes
work/openssl
key: codeql-work-${{ inputs.runtime }}-${{ hashFiles('util/**/*.sh', 'util/**/*.pl', 'util/**/*.awk', '.github/**/*.yml', '.github/**/*.sh', '.github/**/*.js', 'rust-toolchain', 'Makefile') }}
key: codeql-work-${{ matrix.os }}-${{ matrix.cc }}-${{ matrix.ngx }}-${{ matrix.openresty }}-${{ matrix.runtime }}-${{ hashFiles('util/**/*.sh', 'util/**/*.pl', 'util/**/*.awk', '.github/**/*.yml', '.github/**/*.sh', '.github/**/*.js', 'rust-toolchain', 'Makefile') }}
- name: Setup Wasm runtime
run: ./util/runtime.sh -R ${{ inputs.runtime }} -V ${{ inputs[inputs.runtime] }}
run: ./util/runtime.sh -R ${{ matrix.runtime }} -V ${{ matrix[matrix.runtime] }}
- run: make setup
- run: make
env:
NGX_WASM_RUNTIME: ${{ matrix.runtime }}
NGX_BUILD_OPENRESTY: ${{ matrix.openresty }}
NGX_BUILD_DYNAMIC_MODULE: 1
NGX_BUILD_DEBUG: 1
NGX_BUILD_SSL: 1
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
with:
upload: false
output: sarif-results
- id: sarif-filename
run: |
if [ "${{ inputs.language }}" = "c-cpp" ]; then
if [ "${{ matrix.language }}" = "c-cpp" ]; then
echo "name=cpp" >> $GITHUB_OUTPUT
else
echo "name=${{ inputs.language }}" >> $GITHUB_OUTPUT
echo "name=${{ matrix.language }}" >> $GITHUB_OUTPUT
fi
- name: Filter SARIF
uses: advanced-security/filter-sarif@v1
Expand All @@ -80,6 +84,6 @@ jobs:
sarif_file: sarif-results
- uses: actions/upload-artifact@v4
with:
name: sarif-results-${{ inputs.runtime }}
name: sarif-results-${{ matrix.runtime }}
path: sarif-results
retention-days: ${{ github.retention_days }}
Loading