chore(ci) fix release build and artifacts upload #507
Conversation
CentOS 7 and Ubuntu 18.04 need actions/checkout@v3 due to a binary incompatibility with Node 20. See: actions/checkout#1590
More recent versions of V8 don't build with GCC 8.
See: #506 See: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changeses@v4 See: https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes@v4 Co-Authored-By: Caio Ramos Casimiro <[email protected]>
* `docker/login-action` to v3 * `docker/setup-qemu-action` to v3
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
===================================================
- Coverage 90.02022% 90.01315% -0.00707%
===================================================
Files 46 46
Lines 9890 9883 -7
===================================================
- Hits 8903 8896 -7
Misses 987 987 see 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
casimiro
force-pushed
the
chore/ci-fixes
branch
from
0510c33 to
198841e
Compare
|
#508 has fixes for the spurious [warn] issues about the socket deletion. |
casimiro
changed the title
The action `upload-artifact@v4` can't run on Centos 8 and Ubuntu 18.04 so its `v3` counterpart is used; other build jobs in the release workflow use `upload-artifact@v4`. The action `download-artifact@v4` is only able to download artifacts uploaded by `upload-artifact@v4`. See: https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes
casimiro
force-pushed
the
chore/ci-fixes
branch
from
198841e to
b960529
Compare
|
@casimiro branch is looking good, nice to see all the release jobs in green! 💚 I took the liberty to push an extra tmp commit to make it list the downloaded assets, just so we can see that the addition from d74a11c combined all assets as expected. (We can see in the asset list from the previous run that they were all uploaded, but not that the final job was able to download and combine them all.) Once we have that last bit of confirmation, I think this is good to go! |
|
Merged in #510. |
No description provided.