chore(ci) assign unique names to uploaded artifacts #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=============================================
Coverage 90.02022% 90.02022%
=============================================
Files 46 46
Lines 9890 9890
=============================================
Hits 8903 8903
Misses 987 987
Flags with carried forward coverage won't be shown. Click here to find out more. |
casimiro
force-pushed
the
chore/fix-upload-artifact
branch
from
c53abdb to
5153c09
Compare
casimiro
force-pushed
the
chore/fix-upload-artifact
branch
from
5153c09 to
4c0fa28
Compare
Since v4, action `upload-artifact` no longer supports uploading artifacts with non-unique names.
casimiro
force-pushed
the
chore/fix-upload-artifact
branch
from
4c0fa28 to
f062f89
Compare
hishamhm
added a commit
that referenced
this pull request
Feb 14, 2024
casimiro
force-pushed
the
chore/fix-upload-artifact
branch
from
f062f89 to
3c67dc3
Compare
* `docker/login-action` to v3 * `docker/setup-qemu-action` to v3
casimiro
force-pushed
the
chore/fix-upload-artifact
branch
from
3c67dc3 to
c340263
Compare
3 tasks
|
@casimiro Caio, would you mind drafting a PR that takes both @hishamhm's work in #486 and the bits from this PR? Instead of merging #486 and then rebasing this, rather rebasing this PR atop #486. I think |
casimiro
added a commit
that referenced
this pull request
Feb 16, 2024
See: #506 See: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changeses@v4 See: https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes@v4 Co-Authored-By: Caio Ramos Casimiro <[email protected]>
thibaultcha
pushed a commit
that referenced
this pull request
Feb 17, 2024
See: #506 See: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changeses@v4 See: https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes@v4 Co-Authored-By: Caio Ramos Casimiro <[email protected]>
thibaultcha
pushed a commit
that referenced
this pull request
Feb 17, 2024
See: #506 See: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changeses@v4 See: https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes@v4 Co-Authored-By: Caio Ramos Casimiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v4, the action
upload-artifactno longer supports uploading artifacts with non-unique names.