Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests) fix test cases for Wasmer in HUP mode #478

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

thibaultcha
Copy link
Member

@thibaultcha thibaultcha commented Jan 4, 2024

Different compilers load the hostcalls filter faster or slower by an order of magnitude (30ms vs 300ms), and cause the old worker "free instance" log to happen sooner or later in req0, especially now that we update the time at module loading.

@thibaultcha thibaultcha changed the title chore(ci) fix Large CI unit tests in HUP mode chore(tests) fix Large CI unit tests in HUP mode Jan 4, 2024
@thibaultcha thibaultcha changed the title chore(tests) fix Large CI unit tests in HUP mode chore(tests) fix test cases for Wasmer in HUP mode Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Merging #478 (8b020ff) into main (e7769a0) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #478   +/-   ##
=============================================
  Coverage   90.14156%   90.14156%           
=============================================
  Files             46          46           
  Lines           9890        9890           
=============================================
  Hits            8915        8915           
  Misses           975         975           
Flag Coverage Δ
unit 90.24390% <ø> (ø)
valgrind 77.84247% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@thibaultcha thibaultcha merged commit 4011cfb into main Jan 4, 2024
37 checks passed
@thibaultcha thibaultcha deleted the chore/fix-ci-large branch January 4, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant