Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) fix large CI workflow file #463

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

casimiro
Copy link
Contributor

@casimiro casimiro commented Dec 8, 2023

This successful run demonstrates the fix.

@casimiro casimiro force-pushed the chore/large-ci-bug branch 9 times, most recently from 1568352 to ae46f3a Compare December 10, 2023 20:18
@casimiro casimiro changed the title tmp(ci) inspecting large CI output chore(ci) fix large CI workflow file Dec 10, 2023
@casimiro casimiro changed the title chore(ci) fix large CI workflow file tmp(ci) inspecting large CI output Dec 10, 2023
@casimiro casimiro force-pushed the chore/large-ci-bug branch 9 times, most recently from 2bda158 to 77494da Compare December 10, 2023 23:39
@casimiro casimiro changed the title tmp(ci) inspecting large CI output chore(ci) fix large CI workflow file Dec 10, 2023
@thibaultcha
Copy link
Member

Glad that you found the root cause, awesome. How could we fix it without removing the ability to run job-build-tests.yml with different os? E.g. macos-latest in the near future?

@casimiro
Copy link
Contributor Author

While addressing the issue I concluded that the problem was the single-entry bracket-list and that having more than one entry, e.g. os: [ubuntu-latest, macos-latest], wouldn't trigger the error.

But I actually haven't tested adding more entries to that list to confirm. I'll do that.

If having more items on that list also solves the issue, we can simply put the variable os back to the matrix containing ubuntu-latest and the added OS, e.g. os: [ubuntu-latest, macos-latest], when we want to add a new OS.

@casimiro casimiro force-pushed the chore/large-ci-bug branch 2 times, most recently from bf18cbb to d3be8fc Compare December 11, 2023 18:54
Although all its jobs run successfully, the Large CI workflow
has been failing consistently due to a list inside the `include`
field of `build-large` job's  matrix in `.github/workflows/ci-large.yml`.
@casimiro
Copy link
Contributor Author

The fix can be verified in this successful run.

@thibaultcha thibaultcha merged commit 88ec9b9 into main Dec 11, 2023
1 check passed
@thibaultcha thibaultcha deleted the chore/large-ci-bug branch December 11, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants