tests(*) opt-in Valgrind test cases #447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
chore/valgrind-split
branch
from
7dd64b5 to
e9015ff
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
===================================================
+ Coverage 90.18238% 90.18730% +0.00491%
===================================================
Files 46 46
Lines 8444 8489 +45
===================================================
+ Hits 7615 7656 +41
- Misses 829 833 +4
|
Fix a Valgrind memory leak and an unrelated suppression. Dispatch resume invoking on_request_headers for subsequent filters may yield themselves (NGX_AGAIN). In this case, also ensure the dispatch call is destroyed. Fix the suppression for headers-more-nginx-module which can happen with other stacktraces on builtin headers (e.g. Content-Length).
thibaultcha
force-pushed
the
chore/valgrind-split
branch
5 times, most recently
from
4841398 to
9cb3518
Compare
thibaultcha
force-pushed
the
chore/valgrind-split
branch
from
9cb3518 to
7c38cb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworking the way we execute Valgrind checks. ATM, mostly tests on run time for different Wasm runtimes and splitting Valgrind workloads.
The goal of this work will be to make Valgrind tests opt-in: a select set of tests from the whole suite will be enabled for Valgrind testing, therefore avoiding duplicated Valgrind tests (or multiple functional tests with not difference in memory handling), and avoid having to filter-out hundreds of tests only to leave a few enabled ones.