chore(util) replicate runtimes workflow to sdks #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
===================================================
+ Coverage 90.11043% 90.18899% +0.07856%
===================================================
Files 45 46 +1
Lines 8150 8572 +422
===================================================
+ Hits 7344 7731 +387
- Misses 806 841 +35 |
casimiro
force-pushed
the
chore/util-sdk
branch
6 times, most recently
from
cf6b526 to
a19d684
Compare
casimiro
force-pushed
the
chore/util-sdk
branch
from
a19d684 to
4937b43
Compare
casimiro
changed the title
thibaultcha
reviewed
Nov 28, 2023
casimiro
force-pushed
the
chore/util-sdk
branch
from
4937b43 to
1c41715
Compare
casimiro
force-pushed
the
chore/util-sdk
branch
2 times, most recently
from
ee82e5c to
eb0b39d
Compare
|
Thank you for the careful and detailed review @thibaultcha. I'm addressing the issues highlighted in the comments. |
thibaultcha
reviewed
Nov 30, 2023
This commit introduces `./util/sdk.sh` and `./util/sdks/*.sh` to accommodate scripting related to proxy-wasm SDK. It also moves proxy-wasm SDKs download/build from ./util/test.sh to ./util/setup.sh making these workflows consistent with how other dependencies are handled.
casimiro
force-pushed
the
chore/util-sdk
branch
from
eb0b39d to
5490bbe
Compare
|
@thibaultcha I've pushed some final adjustments. I'll push the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a few changes:
A new structure for accommodating Proxy-wasm SDKs compilation scripts;
./util/sdk.shand./util/sdks/*.shresemble the structure and interface of the scripts used to download and build WebAssembly runtimes:./util/runtime.shand./util/runtimes/*.sh.AssemblyScript SDK compilation script and set of tests for the example filters.
./util/test.shonly compiles SDKs when the running tests require them.