Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) bump Wasmer to 3.3.0 #439

Closed
wants to merge 2 commits into from
Closed

Conversation

thibaultcha
Copy link
Member

@thibaultcha thibaultcha commented Nov 1, 2023

TODO

  • more time double-checking wasi_env leak in HUP mode
  • another leak detected locally:
==1340178== 1,024 (512 direct, 512 indirect) bytes in 16 blocks are definitely lost in loss record 57 of 82
==1340178==    at 0x48469B3: calloc (vg_replace_malloc.c:1554)
==1340178==    by 0x65B08A3: __cxa_thread_atexit_impl (cxa_thread_atexit_impl.c:106)
==1340178==    by 0x5C733C1: std:🧵:local::fast::Key<T>::try_initialize (in /home/chasum/code/ngx_wasm_module/work/runtimes/wasmer-3.3.0/lib/libwasmer.so)
==1340178==    by 0x5C756CF: std::sys_common::backtrace::__rust_begin_short_backtrace (in /home/chasum/code/ngx_wasm_module/work/runtimes/wasmer-3.3.0/lib/libwasmer.so)
==1340178==    by 0x5C8DD6D: core::ops::function::FnOnce::call_once{{vtable.shim}} (in /home/chasum/code/ngx_wasm_module/work/runtimes/wasmer-3.3.0/lib/libwasmer.so)
==1340178==    by 0x5E852F2: call_once<(), dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global> (boxed.rs:1940)
==1340178==    by 0x5E852F2: call_once<(), alloc::boxed::Box<dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global>, alloc::alloc::Global> (boxed.rs:1940)
==1340178==    by 0x5E852F2: std::sys::unix:🧵:Thread:🆕:thread_start (thread.rs:108)
==1340178==    by 0x65FC9EA: start_thread (pthread_create.c:444)
==1340178==    by 0x6680653: clone (clone.S:100)
==1340178==
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:calloc
   fun:__cxa_thread_atexit_impl
   fun:_ZN3std6thread5local4fast12Key$LT$T$GT$14try_initialize17h2bea1c855c84557aE.llvm.8405950610511606066
   fun:_ZN3std10sys_common9backtrace28__rust_begin_short_backtrace17h9c91faef54c14282E
   fun:_ZN4core3ops8function6FnOnce40call_once$u7b$$u7b$vtable.shim$u7d$$u7d$17hf6162bd9fccb4b6aE
   fun:call_once<(), dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global>
   fun:call_once<(), alloc::boxed::Box<dyn core::ops::function::FnOnce<(), Output=()>, alloc::alloc::Global>, alloc::alloc::Global>
   fun:_ZN3std3sys4unix6thread6Thread3new12thread_start17h62ca48b42d48a8fcE
   fun:start_thread
   fun:clone
}

@thibaultcha thibaultcha force-pushed the chore/bump-wasmer-3 branch 2 times, most recently from 3a3ec50 to 3a5b844 Compare November 1, 2023 17:24
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #439 (75dcd1e) into main (ecd7896) will decrease coverage by 0.01068%.
The diff coverage is 66.66667%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #439         +/-   ##
===================================================
- Coverage   90.18238%   90.17170%   -0.01068%     
===================================================
  Files             46          46                 
  Lines           8444        8445          +1     
===================================================
  Hits            7615        7615                 
- Misses           829         830          +1     
Files Coverage Δ
src/wasm/wrt/ngx_wrt_wasmer.c 81.16343% <66.66667%> (-0.22546%) ⬇️

@thibaultcha thibaultcha force-pushed the chore/bump-wasmer-3 branch 5 times, most recently from 0375e84 to 75dcd1e Compare November 8, 2023 18:44
@thibaultcha thibaultcha added pr/work-in-progress PR: Work in progress and removed pr/work-in-progress PR: Work in progress labels Nov 16, 2023
thibaultcha and others added 2 commits December 5, 2023 13:49
@thibaultcha thibaultcha closed this Dec 5, 2023
@thibaultcha thibaultcha deleted the chore/bump-wasmer-3 branch December 5, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant