fix(proxy-wasm) resume the filter chain on dispatch response #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dispatch could be during `on_request_body`, and when the response is received, subsequent filters' `on_request_body` steps should also be invoked. This is a rudimentary fix for the time being, but now that the proxy-wasm runloop is fully re-entrant, the resume model could also be refactored into something cleaner and reusable for other C resume handlers. Co-Authored-By: Caio Ramos Casimiro <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #428 +/- ##
===================================================
- Coverage 90.14168% 90.11905% -0.02263%
===================================================
Files 46 46
Lines 8399 8400 +1
===================================================
- Hits 7571 7570 -1
- Misses 828 830 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dispatch could be during
on_request_body, and when the response is received, subsequent filters'on_request_bodysteps should also be invoked.This is a rudimentary fix for the time being, but now that the proxy-wasm runloop is fully re-entrant, the resume model could also be refactored into something cleaner and reusable for other C resume handlers.