Skip to content

Commit

Permalink
chore(release) install Python 3.8+ in older distributions
Browse files Browse the repository at this point in the history
  • Loading branch information
thibaultcha committed Oct 27, 2023
1 parent 3de13bd commit ed0fc23
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
5 changes: 5 additions & 0 deletions assets/release/Dockerfiles/Dockerfile.amd64.centos7
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ RUN yum install -y epel-release && \
perl-IPC-Cmd \
perl-Test-Simple

# Install Python 3.8 (required by V8's GN build system)
RUN yum -y install centos-release-scl-rh centos-release-scl && \
yum --enablerepo=centos-sclo-rh -y install rh-python38 && \
echo 'source /opt/rh/rh-python38/enable; export X_SCLS="`scl enable rh-python38 \\'echo $X_SCLS\\'`"' >> /etc/profile.d/python38.sh

ENV RUSTUP_HOME=/usr/local/rustup CARGO_HOME=/usr/local/cargo
ENV PATH $CARGO_HOME/bin:$PATH
RUN ln -nfs $(which cmake3) /usr/bin/cmake
Expand Down
2 changes: 1 addition & 1 deletion assets/release/Dockerfiles/Dockerfile.amd64.centos8
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-Linux-* && \
libstdc++-devel \
libatomic \
perl \
python3 \
python39 \
git \
glib2-devel

Expand Down
7 changes: 7 additions & 0 deletions assets/release/Dockerfiles/Dockerfile.amd64.ubuntu-18.04
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ RUN apt-get install -y --no-install-recommends \
pip3 install scikit-build && \
pip3 install cmake

# Install Python 3.8 (required by V8's GN build system)
RUN apt-get install -y software-properties-common && \
add-apt-repository -y ppa:deadsnakes/ppa && \
apt-get update && \
apt-get install -y python3.8 && \
echo 'alias python3="python3.8"' >> ~/.bashrc

ENV RUSTUP_HOME=/usr/local/rustup CARGO_HOME=/usr/local/cargo
ENV PATH $CARGO_HOME/bin:$PATH
RUN mkdir -p "$CARGO_HOME" && mkdir -p "$RUSTUP_HOME" && \
Expand Down

0 comments on commit ed0fc23

Please sign in to comment.