fix(lib): allowing page size 1 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luacheck Report2 tests ±0 0 ✅ ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 5d5239f. ± Comparison against base commit 1967f92. ♻️ This comment has been updated with latest results. |
chobits
approved these changes
Nov 21, 2024
StarlightIbuki
force-pushed
the
fix/lmdb-page-size-1
branch
4 times, most recently
from
01c6199 to
3874f51
Compare
chobits
reviewed
Nov 21, 2024
chobits
reviewed
Nov 21, 2024
chobits
approved these changes
Nov 21, 2024
chronolaw
changed the title
dndx
requested changes
Nov 21, 2024
chronolaw
reviewed
Nov 21, 2024
chobits
approved these changes
Nov 21, 2024
StarlightIbuki
force-pushed
the
fix/lmdb-page-size-1
branch
from
1def096 to
2d3dee0
Compare
dndx
requested changes
Nov 22, 2024
StarlightIbuki
force-pushed
the
fix/lmdb-page-size-1
branch
from
2d3dee0 to
abae2b9
Compare
|
@StarlightIbuki This PR needs to fix it's tests and rebase with the correct |
StarlightIbuki
force-pushed
the
fix/lmdb-page-size-1
branch
from
93a4ddd to
59fd8f6
Compare
chronolaw
approved these changes
Nov 22, 2024
Co-authored-by: Xiaochen Wang <[email protected]>
StarlightIbuki
force-pushed
the
fix/lmdb-page-size-1
branch
from
59fd8f6 to
5d5239f
Compare
dndx
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAG-5875