fix(var): patch set_header #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch the `req.set_header` function to invalidate the relevant `variable_index` entry for the modified header. Specifically, after normalizing the header name, the corresponding `variable_index` entry is set to `nil`. This ensures that subsequent accesses to `ngx.var.http_*` variables will bypass the cached index and fetch the updated header value. same fix way as: #59 Fix: [KAG-5963](https://konghq.atlassian.net/browse/KAG-5963) Signed-off-by: tzssangglass <[email protected]>
tzssangglass
commented
Dec 13, 2024
lualib/resty/kong/var.lua
Outdated
| local orig_set_header = req.set_header | ||
|
|
||
| req.set_header = function(...) | ||
| local normalized_header = replace_dashes_lower(...) |
There was a problem hiding this comment.
perhaps I need to unpack the data structure(…) and retrieve the first element; this should be clear.
There was a problem hiding this comment.
right, doesn't the current implementation mean we're passing both header_name and header_value from ngx.req.set_header(header_name, header_value), to replace_dashes_lower?
We can probably patch this set_header function with a function that takes exactly 2 arguments, then use the first (header_name) to invalidate the index.
There was a problem hiding this comment.
I changed to
req.set_header = function(name, value)
local normalized_header = replace_dashes_lower(name)I did not choose the
req.set_header = function(...)
local args = table.unpack(...)
local normalized_header = replace_dashes_lower(args[1])I feel that this will degrade performance.
Signed-off-by: tzssangglass <[email protected]>
samugi
approved these changes
Dec 16, 2024
ms2008
approved these changes
Dec 17, 2024
outsinre
approved these changes
Dec 17, 2024
catbro666
approved these changes
Dec 18, 2024
Signed-off-by: tzssangglass <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch the
req.set_headerfunction to invalidate the relevantvariable_indexentry for the modified header. Specifically, after normalizing the header name, the correspondingvariable_indexentry is set tonil. This ensures that subsequent accesses tongx.var.http_*variables will bypass the cached index and fetch the updated header value.same fix way as: #59
Fix: KAG-5963
Fix: FTI-6406