Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove pulp password usage #900

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Dec 14, 2023

After Kong/kong-license#25 has been merged, we only care about 1Password token so remove the reference to Pulp password.

@pmalek pmalek requested a review from a team as a code owner December 14, 2023 13:46
@pmalek pmalek self-assigned this Dec 14, 2023
@pmalek pmalek added the area/ci label Dec 14, 2023
@pmalek pmalek enabled auto-merge (squash) December 14, 2023 13:46
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dca9f2) 60.18% compared to head (3994bba) 41.20%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #900       +/-   ##
===========================================
- Coverage   60.18%   41.20%   -18.99%     
===========================================
  Files          49       49               
  Lines        4024     4024               
===========================================
- Hits         2422     1658      -764     
- Misses       1298     2161      +863     
+ Partials      304      205       -99     
Flag Coverage Δ
integration-test 41.20% <ø> (-18.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek merged commit 6998d35 into main Dec 14, 2023
41 checks passed
@pmalek pmalek deleted the remove-pulp-password-usage branch December 14, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants