Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kong): allow multiple kong addons to be deployed in cluster #845

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 20, 2023

No description provided.

@pmalek pmalek added the area/feature New feature or request label Oct 20, 2023
@pmalek pmalek self-assigned this Oct 20, 2023
@pmalek pmalek requested a review from shaneutt as a code owner October 20, 2023 12:59
@pmalek pmalek force-pushed the allow-multiple-kong-addons-per-cluster branch from c4c7054 to 2e4cb99 Compare October 20, 2023 13:01
@pmalek pmalek requested a review from a team as a code owner October 20, 2023 13:01
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 13:03 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6983169) 59.67% compared to head (3a703d0) 21.42%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #845       +/-   ##
===========================================
- Coverage   59.67%   21.42%   -38.25%     
===========================================
  Files          49       49               
  Lines        4015     4023        +8     
===========================================
- Hits         2396      862     -1534     
- Misses       1317     3020     +1703     
+ Partials      302      141      -161     
Flag Coverage Δ
integration-test 21.42% <56.25%> (-38.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/clusters/addons/kong/addon.go 14.91% <66.66%> (-45.18%) ⬇️
pkg/clusters/addons/kong/builder.go 38.68% <53.84%> (-42.71%) ⬇️

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shaneutt
shaneutt previously approved these changes Oct 20, 2023
@pmalek pmalek force-pushed the allow-multiple-kong-addons-per-cluster branch from 2e4cb99 to 0c7887d Compare October 20, 2023 14:28
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 14:33 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 14:33 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 14:33 — with GitHub Actions Inactive
shaneutt
shaneutt previously approved these changes Oct 20, 2023
@pmalek pmalek force-pushed the allow-multiple-kong-addons-per-cluster branch from 0c7887d to 3a703d0 Compare October 20, 2023 16:05
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 16:14 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 16:14 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 16:14 — with GitHub Actions Inactive
@pmalek pmalek requested a review from shaneutt October 20, 2023 16:29
@pmalek pmalek enabled auto-merge (squash) October 20, 2023 16:29
@shaneutt shaneutt disabled auto-merge October 20, 2023 17:26
@shaneutt shaneutt merged commit b62d9f9 into main Oct 20, 2023
40 checks passed
@shaneutt shaneutt deleted the allow-multiple-kong-addons-per-cluster branch October 20, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants