Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kong): allow setting Node ports #844

Merged
merged 1 commit into from
Oct 20, 2023
Merged

feat(kong): allow setting Node ports #844

merged 1 commit into from
Oct 20, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 20, 2023

Add possibility to specify NodePorts for kong's admin API and HTTP port.

This is required for Kong/kubernetes-ingress-controller#4823 to prevent tests colliding when deploying multiple kong addons to the same cluster.

@pmalek pmalek added the area/feature New feature or request label Oct 20, 2023
@pmalek pmalek self-assigned this Oct 20, 2023
@pmalek pmalek requested a review from shaneutt as a code owner October 20, 2023 10:30
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 10:44 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (418f3f0) 59.43% compared to head (87b000a) 59.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
- Coverage   59.43%   59.40%   -0.04%     
==========================================
  Files          49       49              
  Lines        3996     4015      +19     
==========================================
+ Hits         2375     2385      +10     
- Misses       1317     1325       +8     
- Partials      304      305       +1     
Flag Coverage Δ
integration-test 59.40% <53.57%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/clusters/addons/kong/addon.go 60.08% <57.14%> (-0.23%) ⬇️
pkg/clusters/addons/metallb/metallb.go 69.06% <20.00%> (ø)
pkg/clusters/addons/kong/builder.go 81.39% <62.50%> (-2.96%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:04 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:20 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:20 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:20 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:40 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:40 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:40 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:52 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:52 — with GitHub Actions Inactive
@pmalek pmalek temporarily deployed to gcloud October 20, 2023 11:52 — with GitHub Actions Inactive
@pmalek pmalek merged commit 8ce2ab2 into main Oct 20, 2023
39 checks passed
@pmalek pmalek deleted the nodeports branch October 20, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants