feat: support disabling generated IPAddressPool #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
force-pushed
the
feat/disable-pool
branch
from
1f52a17 to
0d3b0ca
Compare
rainest
force-pushed
the
feat/disable-pool
branch
from
0d3b0ca to
c4d9d8b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 59.87% 59.53% -0.35%
==========================================
Files 48 49 +1
Lines 3983 3996 +13
==========================================
- Hits 2385 2379 -6
- Misses 1297 1314 +17
- Partials 301 303 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
pmalek
reviewed
Oct 11, 2023
pmalek
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #834 (comment)
Adds a metallb addon builder and a single option, to disable creating the addon's IPAddressPool. If you wish to create your own pool(s) for whatever reason, enabling this lets you do so without risk of the default pool colliding with yours.