Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to deploy Kong Gateway EE in DBLess mode #757

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

programmer04
Copy link
Member

This PR fixes KTF to allow deployment of Kong Gateway EE in DBLess mode. New introduced test TestKongEnterpriseDBLess checks it. The adjustment has to be made for tests for the enterprise version. Instead of using /workspaces that silently doesn't work in DBLess mode when trying to configure them - nothing is created (will be reported to the upstream, but it's rather considered as normal, old, expected behavior) /consumer_groups are used. Consumer Groups work in the same way in both versions.

@programmer04 programmer04 enabled auto-merge (squash) July 25, 2023 13:07
@programmer04 programmer04 temporarily deployed to gcloud July 25, 2023 13:08 — with GitHub Actions Inactive
@programmer04 programmer04 temporarily deployed to gcloud July 25, 2023 13:08 — with GitHub Actions Inactive
@programmer04 programmer04 temporarily deployed to gcloud July 25, 2023 13:08 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Patch coverage: 85.00% and project coverage change: -2.10% ⚠️

Comparison is base (ae6ce7b) 59.40% compared to head (8bfed1f) 57.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   59.40%   57.30%   -2.10%     
==========================================
  Files          44       44              
  Lines        3569     3567       -2     
==========================================
- Hits         2120     2044      -76     
- Misses       1170     1259      +89     
+ Partials      279      264      -15     
Flag Coverage Δ
integration-test 57.30% <85.00%> (-2.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/clusters/addons/kong/addon.go 59.95% <85.00%> (-0.19%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek
Copy link
Member

pmalek commented Jul 25, 2023

TestKongEnterprisePostgres fails :(

@programmer04
Copy link
Member Author

programmer04 commented Jul 25, 2023

flake 🥲

 Error: UPGRADE FAILED: failed to create resource: Service "ingress-controller-kong-proxy" is invalid: spec.ports[0].nodePort: Invalid value: 30080: provided port is already allocated

@pmalek

reported in #677

@programmer04 programmer04 temporarily deployed to gcloud July 25, 2023 13:16 — with GitHub Actions Inactive
@programmer04 programmer04 temporarily deployed to gcloud July 25, 2023 13:16 — with GitHub Actions Inactive
@programmer04 programmer04 temporarily deployed to gcloud July 25, 2023 13:16 — with GitHub Actions Inactive
czeslavo
czeslavo previously approved these changes Jul 25, 2023
test/integration/enterprise_test.go Outdated Show resolved Hide resolved
@programmer04 programmer04 requested a review from czeslavo July 25, 2023 13:46
@programmer04 programmer04 temporarily deployed to gcloud July 25, 2023 13:46 — with GitHub Actions Inactive
@programmer04 programmer04 temporarily deployed to gcloud July 25, 2023 13:46 — with GitHub Actions Inactive
@programmer04 programmer04 temporarily deployed to gcloud July 25, 2023 13:46 — with GitHub Actions Inactive
@programmer04 programmer04 merged commit 208cdc1 into main Jul 25, 2023
@programmer04 programmer04 deleted the enterprise-dbless branch July 25, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants