Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split config change detector into gw and konnect flavor #6942

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jan 8, 2025

What this PR does / why we need it:

Splits the DefaultConfigChangeDetector into KongGatewayConfigChangeDetector and KonnectConfigChangeDetector. As they are now used by two separate components (KongClient and konnect.ConfigSynchronizer), we can remove the client.IsKonnect() conditional from the detector and rely on the dependency injection.

Which issue this PR fixes:

Part of #6340.

@czeslavo czeslavo force-pushed the chore/config-change-detectors branch from a3bd40a to b43fc2c Compare January 8, 2025 12:12
@czeslavo czeslavo self-assigned this Jan 8, 2025
@czeslavo czeslavo marked this pull request as ready for review January 8, 2025 12:25
@czeslavo czeslavo requested a review from a team as a code owner January 8, 2025 12:25
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.9%. Comparing base (40d909f) to head (b43fc2c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/manager/setup.go 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6942     +/-   ##
=======================================
+ Coverage   76.7%   76.9%   +0.1%     
=======================================
  Files        214     214             
  Lines      25139   25169     +30     
=======================================
+ Hits       19299   19371     +72     
+ Misses      4825    4779     -46     
- Partials    1015    1019      +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo merged commit 7a6b9e7 into main Jan 8, 2025
43 checks passed
@czeslavo czeslavo deleted the chore/config-change-detectors branch January 8, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants